Fix bug where immutable entities bypass memoization index during batch processing#6083
Merged
incrypto32 merged 1 commit intomasterfrom Jul 24, 2025
Merged
Fix bug where immutable entities bypass memoization index during batch processing#6083incrypto32 merged 1 commit intomasterfrom
incrypto32 merged 1 commit intomasterfrom
Conversation
isum
approved these changes
Jul 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Immutable entities were bypassing our memoization indexing system. Here's what was happening:
append_row()push_row()normally maintainsstore.get()to returnNonewhile the entity existed in cache, triggering assertion panicsSolution
Change
append_row()to useself.push_row(row)instead ofself.rows.push(row)for immutable entity inserts. This ensures they're properly indexed while preserving the intended performance benefits.